Worst code review experience?

Hard to pick just one, but most were in a big meeting room with 4+ other developers not related to the project and with some playing Monday-Morning-Quarterback instead of offering productive feedback.

In one code review, the department mgr reviewed the code from a third party component library.

<brings up the code on the big screen>
Mgr: "I can't read any of this, its a mix of English and something else."
Me: "Its German."
Mgr: "Then why is 'Button' in English? This code is a mess."
Me: "I'm not exactly sure how I should respond, I mean, I didn't write any of this code."
Mgr: "Yes, but you are using it, so it's fair game for a code review."
Me: "Its not really open source, but we can make requests if you found something that needs to be addressed."
Mgr: "Oh yes, all this...whatever this is..<pointing again to the German>"
Me: "I don't think they will change their code to English just so you can read it."
Mgr: "We paid good money, you bet your ass they'll change it!"
Me: "I think the components were like $30 for the unlimited license. They'll tell us to go to hell first. Is there something about my code you want to talk about?"
Mgr: "<Ugggh>...I guess not, I couldn't get past all that German. Why didn't we go with an American company? Hell, why didn't we just write these components ourselves!?"
Me: "Because you gave a directive that if we found components that saved us time, to put in a request, and you approved the request. The company is American, they probably outsourced or hired German developers. I don't know and not sure why we care."
Mgr: "Security! What if they are sending keystrokes back to their servers!"
Me: "Did you see any http or any network access?"
Mgr: "How could I? The code is in German!"
Monday-Morning-Quarterback1: "If it were me, I would have written the components myself and moved on"
Me: "No, I don't think you could for less than $30"
Monday-Morning-Quarterback2: "Meh...we get paid anyway. Just add the time to the estimate."
Mgr: "Exactly! Why do we even have developers who can't read this mess."
Me: "Oh good Lord! Did anyone review or even look at my code for this review!?"
<silence>
Mgr: "Oh...ok...I guess we're done here. Thanks everyone."
<everyone starts to leave>
Me: "Whoa!...wait a sec..am I supposed to do something?"
Mgr: "Get that company to write their code in English so we can read it. You have their number, call em'...no...wait...give me their number. You keep working, I'll take care of this personally"

In they nicest way possible, the company did tell him to go to hell.

It's an emotional rollercoaster when something good happens unexpectedly and you have no one to share/celebrate it with.

Okay, this has to be said.

I am sick and tired of YouTube web devs who went to bootcamp, developed software for around 1 year, quit… then tell everybody what it’s like to be a “programmer.”

To top it off they become “developer advocates.”

Stop misleading people with your clickbait!

Data Engineering cycle of hell:

1) Receive an "beyond urgent" request for a "quick and easy" "one time only" data need.

2) Do it fast using spaghetti code and manual platforms and methods.

3) Go do something else for a time period, until receiving the same request again accompanied by some excuse about "why we need it again just this once"

4) Repeat step 3 until this "only once" process is required to prevent the sun from collapsing into a black hole

5) Repeat steps 1 to 4 until it is impossible to maintain the clusterfuck of hundreds of "quick and simple" processes

6) Require time for refactoring just as a formality, managers will NEVER try to be more efficient if it means that they cannot respond to the latest request (it is called "Panic-Driven Development" or "Crappy Diem" principle)

7) GTFO and let the company collapse onto the next Data Engineering Atlas who happens to wander under the clusterfuck. May his pain end quickly.

Me, complaining about being single: It would just be nice to have someone who cares how my day went every day

Scrum master: Hey...

Me: No

You guys are not ranting enough for me to doomscroll away my miseries here.

After 4 months of remote working I can honestly say the biggest downside is that weed is really really expensive, even if you grow it.

devRant is so refreshing. my circle runs more in the LinkedIn space, so i naturally get on there more. but every few weeks i come back to devRant and get the pure, honest thoughts of developers and it’s always great

just appreciate the realness on here

Merry Christmas everybody

our clients are basically asking us to decide for them the requirements and that's simply absurd? they're supposed to tell us what the hell they want. if we actually take creative liberties, i bet it'd take a day for them to ask for a do over

As a developer, sometimes you hammer away on some useless solo side project for a few weeks. Maybe a small game, a web interface for your home-built storage server, or an app to turn your living room lights on an off.

I often see these posts and graphs here about motivation, about a desire to conceive perfection. You want to create a self-hosted Spotify clone "but better", or you set out to make the best todo app for iOS ever written.

These rants and memes often highlight how you start with this incredible drive, how your code is perfectly clean when you begin. Then it all oscillates between states of panic and surprise, sweat, tears and euphoria, an end in a disillusioned stare at the tangled mess you created, to gather dust forever in some private repository.

Writing a physics engine from scratch was harder than you expected. You needed a lot of ugly code to get your admin panel working in Safari. Some other shiny idea came along, and you decided to bite, even though you feel a burning guilt about the ever growing pile of unfinished failures.

All I want to say is:

No time was lost.

This is how senior developers are born. You strengthen your brain, the calluses on your mind provide you with perseverance to solve problems. Even if (no, *especially* if) you gave up on your project.

Eventually, giving up is good, it's a sign of wisdom an flexibility to focus on the broader domain again.

One of the things I love about failures is how varied they tend to be, how they force you to start seeing overarching patterns.

You don't notice the things you take back from your failures, they slip back sticking to you, undetected.

You get intuitions for strengths and weaknesses in patterns. Whenever you're matching two sparse ordered indexed lists, there's this corner of your brain lighting up on how to do it efficiently. You realize it's not the ORMs which suck, it's the fundamental object-relational impedance mismatch existing in all languages which causes problems, and you feel your fingers tingling whenever you encounter its effects in the future, ready to dive in ever so slightly deeper.

You notice you can suddenly solve completely abstract data problems using the pathfinding logic from your failed game. You realize you can use vector calculations from your physics engine to compare similarities in psychological behavior. You never understood trigonometry in high school, but while building a a deficient robotic Arduino abomination it suddenly started making sense.

You're building intuitions, continuously. These intuitions are grooves which become deeper each time you encounter fundamental patterns. The more variation in environments and topics you expose yourself to, the more permanent these associations become.

Failure is inconsequential, failure even deserves respect, failure builds intuition about patterns. Every single epiphany about similarity in patterns is an incredible victory.

Please, for the love of code...

Start and fail as many projects as you can.

The first time I realized I wasn't as good as I thought I was when I met the smartest dev I've ever known (to this day).

I was hired to manage his team but was just immediately floored by the sheer knowledge and skills this guy displayed.

I started to wonder why they hired outside of the team instead of promoting him when I found that he just didn't mesh well with others.

He was very blunt about everything he says. Especially when it comes to code reviews. Man, he did /not/ mince words. And, of course, everyone took this as him just being an asshole.

But being an expert asshole myself, I could tell he wasn't really trying to be one and he was just quirky. He was really good and I really liked hanging out with him. I learned A LOT of things.

Can you imagine coming into a lead position, with years of experience in the role backing your confidence and then be told that your code is bad and then, systematically, very precisely, and very clearly be told why? That shit is humbling.

But it was the good kind of humbling, you know? I really liked that I had someone who could actually teach me new things.

So we hung out a lot and later on I got to meet his daughter and wife who told me that he had slight autism which is why he talked the way he did. He simply doesn't know how to talk any other way.

I explained it to the rest of the team (after getting permission) and once they understood that they started to take his criticism more seriously. He also started to learn to be less harsh with his words.

We developed some really nice friendships and our team was becoming a little family.

Year and a half later I had to leave the company for personal reasons. But before I did I convinced our boss to get him to replace me. The team was behind him now and he easily handled it like a pro.

That was 5 years ago. I moved out of the city, moved back, and got a job at another company.

Four months ago, he called me up and said he had three reasons for us to meet up.

1. He was making me god father of his new baby boy
2. That they created a new position for him at the company; VP of Engineering
and
3. He wanted to hang out

So we did and turns out he had a 4th reason; He had a nice job offer for me.

I'm telling this story now because I wanted to remind everyone of the lesson that every mainstream anime tells us:

Never underestimate the power of friendship.

I'm a full stack developer because I hate working with other people

Always, always, with every estimate in time or resources you or your pm/manager/whatever thinks to need. Multiply that number by pi.

That's a more real-world estimate.

I got assigned approximately 20 tasks, all are high priority.

Coworker got assigned 2 tasks, (“like fix button sizes and padding”, “localisation “)

He completed.

I got questioned: “are you sure you are a senior developer? Are you doing your work at all? If your coworker can finish low priority tasks in a day , why you as a senior can’t? “

Me :”if you have the ability to see , please tell me how many tasks I have that are in high priority.”

“Exactly, I need you to complete it now , I expect more from you as a senior. “

Me: “why not you tell me which tasks are higher priority? Because can’t be all are urgent. If everything is urgent , nothing is urgent.”

“Stop giving excuses, be a team player.”

Me :” how is it making excuses for asking urgencies of the tasks?”

“Hahaha you called yourself a senior. What a joke”

Me:”likewise, you called yourself a Project manager yet can’t manage. What a joke indeed.”

Had my first Interview in more than 3 years.
What an adrenaline rush!
I'm feeling like I just rockclimbed an active volcano.

Pointer to the void: dynamic_cast<Moon*>(ptr)

A personal memo to all developers on devRant:

* Assume every external line of code, (including every service you consume) is an unreliable crock of flaming shit. These services can and will fail in the most glorious ways. Write your code to be resilient, and ASSUME FAILURE of dependencies. Even if it's your own team writing the other service.

Heard in a meeting today: "Your team's service outage is going to cause my service to corrupt the database!"

Response I wanted to give: "No, you asshat, my service outage is a normal part of living with microservices. Your app should have been smart enough to recognize the failure."

Is it done yet?

Stop micromanaging! We are providing updates every morning, what difference does it make to ask for the update in the evening?!? Don't think no one can see that all you are asking is "is it done yet?"

Like a small child who does not understand the concepts of travel yet, you won't understand why "such a small change" takes so long. It's because we are scooping all the crap, patched by assholes who cared only to please you and did not had the courage to say no to your pressure and do things smart way.

If you think it is necessary to keep reminding everyone to do their job - then you you do not belong in IT.

Dear people who complain about spending a whole night to find a tiny syntax error; Every time I read one of your rants, I feel like a part of me dies.

As a developer, your job is to create elegant optimized rivers of data, to puzzle with interesting algorithmic problems, to craft beautiful mappings from user input to computer storage and back.

You should strive to write code like a Michelangelo, not like a house painter.

You're arguing about indentation or getting annoyed by a project with braces on the same line as the method name. You're struggling with semicolons, misplaced braces or wrongly spelled keywords.

You're bitching about the medium of your paint, about the hardness of the marble -- when you should be lamenting the absence of your muse or the struggle to capture the essence of elegance in your work.

In other words:

Fix your fucking mindset, and fix your fucking tools. Don't fucking rant about your tabs and spaces. Stop fucking screaming how your bloated swiss-army-knife text editor is soooo much better than a purpose-built IDE, if it fails to draw something red and obnoxious around your fuck ups.

Thanks.

!!fml

"Root, go fix this bug. It'll take you two days."

The "bug" is a feature that was never implemented for one particular payment type.

The code in question is two years old, full of typos, smells, junior-isms, and is convoluted AF. The feature's commit touched 190 files and implemented many other features as well. Thus far, I have been unable to narrow down where this particular feature's code lives for the other payment types, nor which code or payment paths lead to it. Burned out, I can barely focus on the screen, let alone follow its many twisting and dynamically-inferred paths. I hint as to the ticket's scavenger hunt nature during standup.

"But I wrote comments on the ticket telling you exactly where to look to fix it," Thundercunt admonishes in front of the team.

"Sure, you did," Root replies. "You reworded what the original dev had said in the comments 20 minutes prior, and agreed with him. His comments were helpful, but it doesn't tell me how any of it works," she continues.

TC scoffs and closes the meeting.

Root stares blankly, seeing neither code nor screen, questions her life decisions, and recalls the previous tickets she has worked on: nearly every one of them busywork, fixing other people's bugs. Bugs she never could have gotten away with if she tried.

"Why do I put up with this?" She asks. "They don't care, and it's killing me."

But the bills remain, and so must she.

"Fuck my life" she finally decides.

Being a programmer is basically like seeing all the cool tech that you always wanted to work with slip right out of your fucking hands and being replaced by an old system that bad programmers have managed to fuck up completely beyond saving. It’s like watching a bunch of monkeys trying to create a human out of decaying flesh, but when you question them, they look at you weird. It’s like wanting to create all these crazy cool animations and innovative experiences, but you end up spending most of your time trying to get a fucking image to line up correctly in marketing emails. My pride has been stripped from me.

Just a friendly reminder to fellow developers to take care of yourself.

If your system is constantly pumping out cortisol, even when threats are minor, it gets desensitized to the stress signals. We used to react to cortisol with the fight-or-flight response when our lives were in real danger. Nowadays it's produced when you disagree with your coworker or there's a deadline coming up. So your cortisol rises but you neither fight nor run. The result is a stress response that isn't functioning properly. This is when burnout symptoms develop. Same goes for testosterone, dopamine and some other hormones and neurotransmitters. Read up and start proper work hygiene that includes workouts, fresh air activities and manual hobbies.

Your back, wrists and eyes aren't the only things you have to watch out for when coding long hours. Cheers and have a fun weekend!

Was given a fancy looking pen for 3 years of “service” today.

Pen doesn’t work.

No. Still nothing about students.
https://blog.heroku.com/new-low-cos...

Show your eco plans up your ass