Details
-
About<3 programming
-
Skillsovercoming obstacles
-
Locationisrael
-
Github
Joined devRant on 10/1/2016
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
==============
Getting Feedback Rant!
=============
When "this is simpler" feedback results in a function of 500 lines of code.
When I get "don't do X" in the feedback. Thank you very much. What do you want me to do instead?
Unclear feedback.
When the feedback giver changes his mind after I applied the changes!
When applying the feedback introduces a bug.
Simply opinionated feedback that is not enforced by any tool or backed up by any facts.
Please find something better to do in life.
Unactionable feedback.
"Consider X"
I will not consider thank you very much.
"Verify this works"
Duh..
When the feedback giver knows something that you don't.
I know this is a legit case.. still annoying.
"I disagree with the feature"
Go argue with the PM, not relevant to me, thanks!
=====================
GIVING FEEDBACK RANT
=====================
I rewrote the system. Please review it.
No need to review, just approve.
I will change this as part of the next ticket.
I would like to keep it the way it is.
lazy ass..
You can't test this.
It's impossible to test this.
No need to test this.
There's no point to test this.
I'll test this on production.
Not sure why this is working..
Please document this..
Because documentation is like a thing, you know.
Oh, this code is not related to this PR, I just don't want to open a new branch for such a small change. ignore it.
Ignore this.
This will be meaningful in my next change. -
class name for section named "liability" is "liab"
class name for section named "dedcutible" is "deduct"
class name for section named "personal property" is "personal-prop"
class name for section named "personal liability" is "personal-liab"
I don't know who you are, but you are a twisted evil teammate and I wish you fired.
You've ruined my day, hope you're happy.2 -
Just closed a TOP PRIORITY ticket with "as designed"..
After a 1 minute talk with the developer who wrote this code, I found it is actually deliberate..
So I just closed the ticket..
but what really bothers me is:
That developer, is sitting right next to the QA.
HE IS SITTING RIGHT THERE..
We are a small startup company, everyone are sitting around the same table..
communicate much?1 -
jim :"this is not a bug.. you just can't use localhost for developing on your machine.. it is forbidden.. things break"1
-
only developer with linux. everyone else are on windows.
constantly finding myself in following conversation
me : "something is not working for me on the web page i am writing"
jim : "let me see just a.... WOW! WHAT IS THIS?"
me:"ubuntu"
jim:"wat?"
me:"linux"
jim:"well... " +sigh + "that's your problem right there! this works to everyone else. and they're on windows. why would you ever not use windows?"
me:"have you ever tried anythig else?"
jim:"never needed to. windows works just fine.."
me:"well... does your computer ever freeze?"
jim:"constantly"
me:"that doesn't happen on ubuntu. at least it is quite rare"
jim:"nah... you're mistaken. windows rocks! anyway, you should probably talk to someone who knows ubuntu cause my chrome works just fine so it must be this ubuntu of yours.."14 -
after spending a day figuring out why my code does not work, i finally realized someone broke master
then i found myself in the following conversation
jim : "yeah, we found out about it yesterday, i am working on a fix right now"
me : "so why did you not send and email to everyone that master is broken, don't pull changes"?
jim : "hey... someone told me to fix it, so that's what i am doing. that doesn't include sending an email. if you want to, you can send it.. "7 -
reading the project's code, following "save" callback in jvascript, i find this comment "IMPORTANT : this is a workaround to solve memory leak" and below it code that basically removes all elements from th DOM and adds them again.
so basically, someone could not find a cause to a memory leak and decided "solve it" in a specific place by reloading almost an entire page