A miracle is needed indeed...

That moment.....

Time for a soap box rant.

I just found this in one of our projects. I've simplified the example to make it more anonymous.

When I see code like this it automatically means there is a lack of attention to enumerations and/or understanding of what they are.

One may argue that in a certain execution of code it's a minor performance hit and therefore insignificant. It's still a performance hit. Furthermore, it takes even less time to do it the right way than it does to do it the wrong way.

Every one of these lines will enumerate the list from the beginning to try and find that one element you're interested in. Big O notation, people.

Throw that crap into a dictionary or hashset or similarly applicable data structure with direct reads at the beginning of your logic so that it only gets enumerated ONCE when the data structure instance is created. Then access it however many times you want.

Soap box rant over.

This passes all unit tests

My colleague has spent 3 days writing a responsive menu that has 5 items in it with no nesting that needs to move to a sidebar on mobiles.

I think that should be maximum 30 lines html and max 40 lines css. Or at least around that sort of area.

He has 150 lines html, 200 lines css, and is not even finished yet. He also made 2 entirely different menus for different screen sizes instead of using media queries...

The reasoning from all my colleagues is that its because the menu needs to use css grid (it doesn't they just randomly decided we can't use flex, float or online).

Working with people that give reasons for their garbage code that literally makes no sense every day gives me a headache....

Well these are the EA devs..

(Its Command and Conquer: Rivals..)

why do you do this to me, school

(NOTE: this is the staff-only network.)

Boss: I have a demo NOW, but there os an error message on that page.

Me: okay, give me sometime to elaborate the problem..

Boss: No No please, this is urgent

Me: Okay..

My code:

😅😅😅

Fork it....

In lame man terms..!