8

when a senior and tech lead write conflicting PR comments ~1 week apart

i dont give a fuck, ill do it either way you want but you 2 need to sort out how the fuck you want it

Comments
  • 2
    Or the same person writes conflicting comments 1 week apart.

    Sorry about that...
  • 3
    So point it out and tell them to get back you when they decide
  • 1
    3...2...1...FIGHT
  • 1
    That's an opportunity to open up a discussion with the wider team on what approach the team wants to take. The conversation and decision should be captured in the PR before it is merged and shouldn't be merged before that happens.

    As the author, you should be the one pushing for that decision. It'll never be made if you leave it to them.
  • 0
    do both and commit in order
Add Comment