I have been told to create smaller PRs, so now every big PR has a few other smaller ones associated. Hope my manager will be happy.

That's bullshit. Create smaller tickets. Then say, one pull request per ticket. That's the way.

If he creates huge tickets, pull requests will be huge.

wtf... how ..... what..... huh??

How the FUCK are you supposed to create smaller PRs?

@TrayKnots tickets can’t always be small, some pieces of work can’t be done with small changes without putting a mess
I just like those big pieces of work.

@Tounai

I agree, cannot always be small. But we have just moved the responsibility to whomever makes the tickets. If that person cannot make a small ticket, you cannot make a small pull request. That's how simple it is.

Tomorrow you'll scarp the rest of the big PR when you get a comment on the small one that changes everything 😉

@TrayKnots
In fact I wrote the ticket.

@Tounai

Kind of expected you to say this. The complain is upstream.

Just tell whoever complained he should complain to the moron writing the big tickets and when that person asks who wrote it, turn around, put on a baseball cap, turn back and say: "That would be me."

big ticket -> small tickets

PR for each small ticket

not all tickets have a PR, but every PR has a ticket

---

if something gets fundamentally changed there's no avoiding having to change a lot of code

... the director of the department told me they wanted to refactor the code and they had a bunch of code debt, so whenever the lead kept giving me tickets to work on I would improve the code around it. then she called my PR a "red flag" because apparently I changed too much. MIXED MESSAGES. I just made the logging system more concise and informative (because I saw earlier the director was having trouble tracing data through the logs because info he needed wasn't being logged from the code) and removed some code duplications... zzzz. I don't get people

Most of my PR’s are big lol

Which kinda stuff do people say you should've excluded from your PR?

---

Personally the last "Is the PR too big?"-debate I was part of was when we built a new website from scratch.

Co-worker got the ticket "Add menu bar with userName". The codebase at that time was in it's infancy so it didn't have much CSS for the site layout. And our test-suite did not have the capability to run clientside JS (which would be responsible for rendering the userName)

The resulting PR added a ton of code to our general site layout HTML/CSS to make sure the site looked like the design, and a ton of code to our test runner to make sure it could run clientsideJS.

I felt this was admirable work. But the PR got stuck in review for days and days as people debated the details the CSS layout and the pros and cons of different types of JS-runners in test suites.