5

To my vigilant code review overlords, yes, I appreciate the scrutiny, but must we nitpick every variable name? I've been told my camelCase is more like llamaCase.
Let's focus on real bugs, not whether my indentation is an affront to nature.

Remember, the perfect code doesn't exist – unless you're coding on a cloud XD

Comments
  • 5
    Just add a formatter to the pipeline - or to your git hooks.

    More than once I told people that thinking and trying to invent clever rules for naming, indentation or the general "but I like it more this way" type of reasoning takes away more time than it actually saves while reading the code.

    Especially if people make it a habit to nitpick in PR.

    Thus the usage of GIT hooks. Format it *before* it lands in an PR.

    Anyone that then starts nitpicking gets a link to the GIT hook documentation page and a "code is formatted according to standards and documentation" comment.

    Plus if it accumulates, they land on my naughty list, meaning I have a very close eye on them, because these kinds of delays make it hard and frustrating for everyone.
  • 0
    just call everything value, or data

    Code like a ninja
  • 0
    var x = some data

    var y = more data

    var bug = I don't know

    ---

    Reviewer: There is a bug in your code, fix it!

    Imagine that happens for real lol
  • 0
    Fuck your indentation opinions. Fuck your tab/spacing opinions.

    Does it work you douchebag?
Add Comment