6
jhole89
7y

My pull request is currently being blocked because my imports aren't alphabetically ordered...

Comments
  • 0
  • 0
    For my projects I prefer order by length but at work no way I'd request nor check for that, on my projects I do whatever I want but when working with others no bugs + task done is the real deal and not alphabetically ordering imports 😒
  • 4
    *whispers quietly* “As it should be”...

    As a disclaimer, if this is a guideline and everyone has to stick to it, I think it’s fine and everything will be internally consistent. Otherwise you’ll be back in 6 months and import something but it’ll already be imported you’ll just not have noticed. But if it’s someone applying a specific rule you, they’re an ass.
  • 1
    @CrankyOldDev except all decent IDE's will highlight when you have repeating imports
  • 0
    isort is your friend! 😇
  • 0
    @jhole89 Meh... details. I'm still right! 😁
  • 0
    @CrankyOldDev stop using vim for development!!!
  • 0
    @jhole89 You can accuse me of many things. But I will not tolerate being called a vim user. Take that back!
  • 2
    @jhole89 @CrankyOldDev what's wrong with vim? :(
  • 2
    @jhole89 my vim highlights repeating imports. And non sorted ones, too.
  • 2
    @shellbug yep. Mine too. It even highlights when I'm using a class that's not imported. Vim is really cool if you give it time.
Add Comment