3

New hate: submodules...
So easy to get things fucked up without even knowing 😖

Comments
  • 0
    what happened?
  • 0
    @plusgut Long story, but we had a PR for the parent repo and just a branch for its submodule. The submodule's branch had a schema update that was needed for some other PRs. The update PR for the parent repo was merge, but no one detected the PR-less submodule's branch with the schema update. Some PRs based on the first were ok and had the update, but a more recent PR was failing even though it was the same as master. Turns out the parent repo master branch was pointing to the updated submodule's branch and the failing PR was pointing to the submodule's master branch (didn't had the update).
    An afternoon lost...
Add Comment