5

Just putting this out there.

Comments
  • 3
    1. variable name should be `eligibilityType`. The fuck is "eligibleType"? How TF would one know what to search for?

    2. multiple possible values for the variable, so use enums (or constants). Why the magic strings?

    3. ''==" returns booleans, so wtf is `(x==y) ? true:false` ?

    Yeah I am mad at small things if those small things make a big giant pile.
  • 2
    @nanobot :) small details matter.

    And for enum constants WITH_TRACKING would make more sense.

    That triggered me xD
  • 1
    Ah yes, if you didn't know, dear reader, if A is true, A is true!
Add Comment