Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
I would be more agitated with the code reviewers that approved the PR and didn't provide constructive feedback to the intern. The intern is there to learn, make mistakes, learn from them, fix them and continue on that path. I understand there's a bar that he/she should meet and should at least know basic coding guidelines, but if your company didn't provide this intern with a mentor, then shame on them. Can't place all the blame on the intern.
-
@forceQuit
I agree. Besides I'm the least one who would not explain something to someone (or learn something for myself. I do make mistakes too) but sometimes you have to deal with the type of intern who just got his diploma and thinks now he knows everything there is to know. -
@Arigion yeah, I don't appreciate the ones that come in thinking they know it all and then they try to commit shitty code. They should know their place. But again, needs a mentor or dev lead to put him/her in their place.
I have to refactor code from an intern. He's VERY lucky that he already left the company.
If I'd say he programms like the first human that would be very insulting to that first human.
It looks like code at first sight, but when you try to understand what he was doing to achieve his goal you get a brainfuck. Duplicate code, unused code, dumb variable names like blRszN.
He wrote unittests like "expects Exception to be thrown or Server returns Statuscode 500".
Yes, Exception, the generic one.
THESE FUCKING TESTS ARE GREEN BECAUSE YOU DID NOT ACTUALLY TEST SOMETHING.
GREEN IN THIS CONTEXT MEANS: YOUR PRODUCTION CODE IS A BIG PILE OF SHIT.
I already removed 2 bugs in a test which caused another exception than the "expected" one and the test does still not reach the actual method under test.
Dumb fucktard.
The sad thing: The fuckers who did the code reviews and let this shit pass are still here writing code.
undefined
retarted intern useless code reviews