Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
C0D4682322yBand-Aid fixes,
Logic bombs,
Nested loops,
Database queries in loops,
Things that make you go eeeewwwww
In general, anything shocking that a junior would write, or will cause performance issues. -
@Demolishun yup. WTF/min, the scale for code quality. Lower numbers means better quality. It’s practically impossible to achieve the value 0.
-
@Lensflare is because I got that in an interview today I was unable to respond correctly
-
horus30572yDoes the changed part of the app even compile? (might be done by Ci)
Does it pass every test (might be done by CI)?
Dies it survive me, manually testing?
Then Look at the Code.
What has the linter to say?
What did they do and does it makes sense?
Did they handled error cases? Did they used appropriate return codes, exceptions, error prompts...
Are all file, function an variable namens meaningful?
Was it really neccessary to introduce this dependency? (defaults to no)
Do the unit tests cover everything sich could potenrially happen? Why did they didn't write any?
Related Rants
so what do you look when you do a "code review" anyway?
question
interview
interview question