Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
Well, yeah! All joking aside, that's exactly what you should do:
- shelf your changes
- approve their PR so they can have some peace of mind
- then immediately raise your own PR
But I'm telling you what you already know... right? -
asgs115633yAs a reviewer, add comments and ask them to fix stuff. Until then, the PR will be in "requiring more changes" or something
-
You should stop yourself from **adding minor changes*** in somebody else's PR.
Why don't you add comments, have discussions on what can be better and how. Let them finish what they have started. Help them grow, teach them, learn from them. Be a good colleague/senior.
Or work alone -
A PR is meant for reviewing.
It's a reviewers job to comment, not to work on the PR.
And a PR should never be merged unless it is fully baked.
Quick ejaculations lead to major frustrations.
I was supposed to just review the PR. But I couldn't stop myself from making minor changes.
It has been 4 hours now. I'm thinking if I should raise a PR for the PR.
rant