I don't get why this retard keeps ignoring my comments on a PR he asked me to review. He is a level above me so I can't push it. I just approve his PR and let him know I do so but with a comment. He then ignores the comments and merges his rubbish changes into the codebase thereby creating a tech debt.

If you're using GitHub there's an option to request changes instead of approve

What can they do if you don't approve?

Either accept your feedback or the process is broken and don't bother

@dan-pud The issue is i'm not the only with approval rights. Everyone in the team can do so. He just circumvents me and gets approval from others. The other fucking nutjobs in the team also ignore my comments on a PR and approve! It appears they just want to create tech debt because it's a consulting gig with a client.

Yeah, the process is clearly broken. I'd simply stop reviewing. If they ask why, cite half a dozen examples of this behaviour and it should be pretty self-evident.

Sounds like a broken process because of the lack of respect for one's colleague's opinions.

I've personally sat through an hour long <strike>argument</strike> debate over stuff in the PR as petty as whether a variable should be cast as a let or a const (an extreme example ofc), but it doesn't feel disheartening because at least you are being heard and respected.

Don't approve until they have at least replied to your comment. By approving, you're part of the problem.

@electrineer yea I agree.