selfrespect++ - I made my very first pull request to a project of public interest. It's just a paragraph in the React docs, but still. I - devRant

Ranter

Comments

2

N00bPancakes

7217

5y

This is the appropriate response:

https://youtube.com/watch/...
1

asgs

10912

5y

@N00bPancakes you are calling him "the" jerk?
1

rantsauce

6701

5y

That's a step many of us struggle to reach. Kudos!
1

N00bPancakes

7217

5y

@asgs well it would be my response
2

lorentz

15360

5y

@N00bPancakes It really does feel like that, although they didn't merge it yet.
0

lorentz

15360

5y

@Lanfiro I use Arch.
1

lorentz

15360

5y

I might be overreacting a little but holy shit I just made a PR on React itself.

Just some basic behavior and a warning but damn it feels good to create something useful.

(https://github.com/facebook/react/...)
0

lorentz

15360

5y

Is it bad manners to force-push my branch regularly after opening a PR?
0

rantsauce

6701

5y

@homo-lorens No. You can mark the pull request as a draft though.
0

lorentz

15360

5y

@rantsauce But it isn't. I just keep finding minor issues in the PR that I really don't think should take up an extra commit in React.
1

Wisecrack

9353

5y

> It's just a paragraph in the React docs, but still.

Oh god, you're one of those types.

j/k.

Seriously, documentation is one of the most underrated contributions imo.

Related Rants

devRant © 2021 Hexical Labs LLC
Privacy Policy | Terms of Service