Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
I'm amazed when formatting is an issue like this. Decent IDEs just let you auto format to a defined standard before committing - turn that on, job done.
-
cho-uc19624y@AlmondSauce
I don't think IDE can help in this case.
He wanted the order of the special member classes to follow specific order. -
evanjs874y@AlmondSauce while the tools definitely exist, there are other, often more difficult barriers to breach.
Like getting everybody to use the same tool (or plug-in, whatever), agree on “standard” settings, etc. ... -
cho-uc19624y@mundo03
That's interesting, but so far I haven't found what can help.
Unless you can tell me how to ensure/automate that each copy assignment should be placed below destructor only if they're in public.
FYI, each class in our codebase also sometimes don't follow specific formatting -
nebula18704yyou can integrate that into your pipelines to ensure that. maybe you can use husky to kinda enforce git hooks, too.
it all depends on the technologies used but i am certain that there is something out there for you. -
mundo0349794y@cho-uc i haven't put effort on building my own linting rules, but I guess it is possible, I have seen some magic in flake8 for python.
Sorry but you will have to research
Related Rants
-
johnmelodyme62[WARNING] THIS RANT IS NOT FOR HULKS OR SHE-HULKS Here we fucking go again, currently, the time is 1:09 am in...
-
tommy7First PR (pull-request) to be accepted by a non-profit!!!!!!
-
IHateForALiving3> make a change > PR gets rejected > IHATEFORALIVING! YOUR CHANGE IS NOT WORKING! EVERYTHING BREAKS! > 3 ho...
In my PR :
Senior dev A : "You should change the format according to <link to coding standard>"
Me : "But it doesn't mention anywhere about that format. <senior dev who wrote the standard> also agrees with me. Other reviewers also already approved."
Senior dev A : **proceed to give me an example from a file that's not even in the PR scope**
Me : "I cannot find that file in my PR"
Senior dev A : **give me another example example from my PR**
Me : "Okay I missed that, I am gonna fix it, but other files are already using consistent format. I have already merged changes for 500 files using this format, and I still have 400 files to go.
Do you really want me to revert the changes from 500 files?" :/
Senior dev A : "I don't want to be your enemy, I just want to make our codebase better"
Me : **Mad because he took this personally.**
**I don't want to be your enemy either. I also care about the codebase. I just want to finish this ticket ASAP instead of implementing your cosmetic changes that's not even in the standard so that I can work on another ticket that will have more impact to the company**
Senior dev A : "Ok, I will approve it, just add some whitespaces"
Me : 🤦♀️
I sometimes think that some senior dev just want to flex when they're reviewing PR.
They just want to let people know they wield the power.
rant
pr