20

Just joined a new team at the organisation as senior dev.

Team lead keeps singing about how we need unit testing and good standards.

I implement domain pattern on the backend supported by unit tests.

It passes QA and then get an earful about the code not being 'restful'. What does that even mean?

Well, it matters not since team lead changes the whole feature in the release branch and all unit tests obviously fails. Builds start to fail.

The solution? Comment out all unit tests. In the sprint retro, we hear the same old adage 'we need 80% code coverage'

Do as i say, not as I do. FML.

Comments
  • 4
    Well, restful is about api’s and when I looked into t there was some debate on where to draw the line ;)

    Some advocate a much more strict interpretation but as far as I have seen there are no real standard, just lots of best practices.
  • 0
    Sounds like you're not doing code reviews (unless that's what you mean by QA.) If you are, then this should have been picked up in the code review. If you're not, then that's on your TL.
  • 0
    @Voxera You are right. It's best to adapt to the situation's requirements than follow the RESTful recommendations to the letter.
  • 1
    @AlmondSauce Code reviews were done by the team and QA by the testing team. Fun fact: The code changes removed validation and error handling. This code went into production the same day with complete disregard for our processes. If you've an explanation for such irrational behaviour, I'd love to hear it.
  • 0
    Didn't I already see this exact post from @whiskey0 ??? WTF
  • 0
    @mysteryos No, that sounds weird as anything.
Add Comment