23

> Last year wrote a unittest - I was asked to delete it
> no design patterns. Not a single one
> no encapsulation
> fucked up inheritance [I had no idea it was possible at all...]
> generics every-fucking-where
> I could go on...

this month the lead dev was not in and I had to make a new feature. Guess what I did :)

tdd [coverage >90%], a couple of builders, a factory or two, two composites, one decorator, only a few generics - only where really needed. Private fields, not a single @Autowired field [they were fucking my tdd], nicely abstracted integrations, and so on. Everything is writen according to clean code: max 10loc methods, <140col lines, reusable constants and utils, SOLID as a rock, etc.

Due date is next week. Took me 3 weeks to craft it.

Guess who's gonna be piiiiiiiiiiiiisssedd 😁

the best part - I don't even work there, our company was hired for xx hours as helping hands 😁

that's not all. They have like 6 envs and their deployment is all-fucking-manual. Will try to learn how to dockerize that app and deploy it on docker. Gosh I wish I could see his face when he's back 😁

p.S. From ethical point of view, he's the only dev who believes his code is perfect. No other dev in the team agrees. AND he once said: 'it's gonna be my way or no way at all'. So I don't think I did wrong... Did I? :)

Comments
  • 5
    You're a goddamn hero.

    And this makes me want to finally read up on some design patterns... I can't always name the ones I use, and I think it would help me think and talk about designs.
  • 5
    @ihatecomputers I say start at refactoring.guru website. This one was by far the easiest to learn from of all I tried. It's very well structured
  • 2
    @netikras
    Thanks!
    My dev dream is to work at a place where work is done the way you described it. I've done a couple of standalone features that way but the rest of the team usually look at me like I'm crazy 😂 Where I'm at now the lead dev doesn't believe in unit tests :( He calls them unnecessary. We have issues every time we deploy to production, hah :d
  • 4
    I'd pay to see this conversation when he gets back
  • 0
    out of curiosity... what was he using all these generics for?
  • 1
    @Krokoklemme in all the services: IDs, DTOs' IDs, some DTOs, etc.
  • 1
  • 0
Add Comment